Skip to content

gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group #125563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 17, 2024
Merged

gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group #125563

merged 13 commits into from
Oct 17, 2024

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Oct 16, 2024 •
edited by bedevere-app bot
Loading

@savannahostrowski savannahostrowski changed the title Deprecate prefix_chars in ArgumentParser.add_argument_group gh-125542: Deprecate prefix_chars in ArgumentParser.add_argument_group Oct 16, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 16, 2024
Closed
@savannahostrowski
Copy link
Member Author

savannahostrowski commented Oct 16, 2024 •
edited
Loading

@serhiy-storchaka I wasn't sure if this should be considered more of a soft deprecation (targeting slated removal in 3.16 or similar) since I'm not really changing logic here to ignore this parameter/throw an error. Interested to hear your thoughts!

savannahostrowski
savannahostrowski commented Oct 16, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Oct 16, 2024
View reviewed changes
@savannahostrowski
Copy link
Member Author

savannahostrowski commented Oct 17, 2024 •
edited
Loading

It looks like using :ref: for parameters doesn't work cross-file (e.g., in news entries). After looking at other examples, it seems the right thing to do here is to use `` instead.

serhiy-storchaka
serhiy-storchaka approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) October 17, 2024 08:48
@serhiy-storchaka serhiy-storchaka merged commit 7b04496 into python:main Oct 17, 2024
36 checks passed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@savannahostrowski @ebonnal
pythongh-125542: Deprecate prefix_chars in ArgumentParser.add_argumen…
2cefcd9 
…t_group() (pythonGH-125563)
donBarbos added a commit to donBarbos/typeshed that referenced this pull request Jul 18, 2025
@donBarbos
[argparse] Deprecate prefix_chars in `ArgumentParser.add_argument_g…
a1cab28 
…roup`

Source: python/cpython#125563
@donBarbos donBarbos mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@savannahostrowski @serhiy-storchaka