-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-125562: Update to documentation for exec* functions #125565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jlownie
wants to merge
14
commits into
python:main
Choose a base branch
from
jlownie:exec_doco
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b5885ee
gh-125562: Updates documentation for exec* functions
jlownie 0a6e161
Minor change to section heading
jlownie 55edd01
gh-125562: Added links between the system(), spawnl() and execl() doc…
jlownie cbadaf5
Update Doc/library/os.rst
jlownie fefa288
gh-125562: Removed incorrect text regarding using subprocess.run inst…
jlownie 7ab5de3
gh-125562: Altered wording before 'argv[0]' in execl documentations
jlownie 090bce8
Apply suggestions from code review
jlownie 22909cb
Merge branch 'exec_doco' of https://github.com/jlownie/cpython into e…
jlownie d339d8f
Merge branch 'main' into exec_doco
jlownie a506cbe
Merge branch 'main' into exec_doco
jlownie 6c35df0
pythongh-125562: Rewording of documentation for execl function
jlownie 8d4d010
pythongh-125562: Rewording of documentation for execl function
jlownie cbeaac2
Merge branch 'exec_doco' of https://github.com/jlownie/cpython into e…
jlownie 5ed449f
Merge branch 'main' into exec_doco
jlownie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you already edited the second sentence, I’ll point out that often the first word on a command line is indeed the program name (e.g. shell command “echo bar”) so saying “not an argument . . . typed on a command line” is confusing if not wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to any suggestions as to better wording? That phrasing came from the original documentation, I agree it's not great but I found it difficult to come up with something better that I was confident was correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my attempt:
The exec functions take a list of arguments for the new program. The first of these is by convention the command name from the command line, rather than an argument to the command, and becomes argv[0] passed to the main function of a C program. For example, os.execv('/bin/echo', ['echo', 'foo', 'bar']) would only print foo bar; the echo argument would seem to be ignored.