-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
Docs: Fix documentation typos in C files #125570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That is, documentation only typos in .c and .h files.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
// Asserts that the mutex is locked. The mutex must be held by the | ||
// top-most critical section otherwise there's the possibility | ||
// that the mutex would be swalled out in some code paths. | ||
// that the mutex would be stalled out in some code paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what swalled
is supposed to mean. I can just revert this change and the same one below if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DinoV wrote this.
Refuse the temptation to guess unless you know what it means.
Having said that, my best guess is “swapped out”. The LL and PP keys are in the same corner of my keyboard.
This comment was marked as outdated.
This comment was marked as outdated.
/* There are two flavours of 'nice': one that returns the new | ||
priority (as required by almost all standards out there) and the | ||
Linux/FreeBSD one, which returns '0' on success and advices | ||
Linux/FreeBSD one, which returns '0' on success and advises |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert. advices
is perfectly legal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Advices seems to be plural of the noun while advises is the verb. I think this is right.
|
||
/* | ||
* Define the PyRecurdingInfinitelyError_Type | ||
* Define the PyRecurringInfinitelyError_Type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Define the PyRecurringInfinitelyError_Type | |
* Define the PyRecursingInfinitelyError type |
// Asserts that the mutex is locked. The mutex must be held by the | ||
// top-most critical section otherwise there's the possibility | ||
// that the mutex would be swalled out in some code paths. | ||
// that the mutex would be stalled out in some code paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DinoV wrote this.
Refuse the temptation to guess unless you know what it means.
Having said that, my best guess is “swapped out”. The LL and PP keys are in the same corner of my keyboard.
Closing this PR. I will follow the suggestions by @willingc in #125569 (review), but also its follow up #125569 (comment). I will apply all suggestions in this PR this far in new PRs, obviously. |
That is, documentation only typos in .c and .h files.
See #125473 for context.