Skip to content

Conversation

ember91
Copy link
Contributor

@ember91 ember91 commented Oct 16, 2024

That is, documentation only typos in .c and .h files.

See #125473 for context.

That is, documentation only typos in .c and .h files.
@bedevere-app
Copy link

bedevere-app bot commented Oct 16, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

// Asserts that the mutex is locked. The mutex must be held by the
// top-most critical section otherwise there's the possibility
// that the mutex would be swalled out in some code paths.
// that the mutex would be stalled out in some code paths.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what swalled is supposed to mean. I can just revert this change and the same one below if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DinoV wrote this.

Refuse the temptation to guess unless you know what it means.

Having said that, my best guess is “swapped out”. The LL and PP keys are in the same corner of my keyboard.

@ember91

This comment was marked as outdated.

/* There are two flavours of 'nice': one that returns the new
priority (as required by almost all standards out there) and the
Linux/FreeBSD one, which returns '0' on success and advices
Linux/FreeBSD one, which returns '0' on success and advises
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert. advices is perfectly legal.

Copy link
Contributor Author

@ember91 ember91 Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Advices seems to be plural of the noun while advises is the verb. I think this is right.


/*
* Define the PyRecurdingInfinitelyError_Type
* Define the PyRecurringInfinitelyError_Type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Define the PyRecurringInfinitelyError_Type
* Define the PyRecursingInfinitelyError type

// Asserts that the mutex is locked. The mutex must be held by the
// top-most critical section otherwise there's the possibility
// that the mutex would be swalled out in some code paths.
// that the mutex would be stalled out in some code paths.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DinoV wrote this.

Refuse the temptation to guess unless you know what it means.

Having said that, my best guess is “swapped out”. The LL and PP keys are in the same corner of my keyboard.

@ember91
Copy link
Contributor Author

ember91 commented Oct 16, 2024

Closing this PR. I will follow the suggestions by @willingc in #125569 (review), but also its follow up #125569 (comment).

I will apply all suggestions in this PR this far in new PRs, obviously.

@ember91 ember91 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants