Skip to content

gh-125588: Teach the python PEG generator the new f-string tokens #125589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

gh-125588: Teach the python PEG generator the new f-string tokens #125589

merged 2 commits into from
Oct 29, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 16, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 16, 2024
Closed
@Eclips4
Copy link
Member

Eclips4 commented Oct 16, 2024

The CI is failing because it is running mypy on Python 3.11, where token.py doesn't have FSTRING_ variables. I think we should bump the Python version for this mypy workflow.

@Eclips4 Eclips4 mentioned this pull request Oct 16, 2024
Merged
@Eclips4
Copy link
Member

Eclips4 commented Oct 16, 2024

I've opened a #125592 for that mypy problem.

AlexWaygood
AlexWaygood reviewed Oct 16, 2024
View reviewed changes
@Eclips4
Copy link
Member

Eclips4 commented Oct 16, 2024

Merging main to get changes from #125592

@pablogsal pablogsal added the type-bug An unexpected behavior, bug, or error label Oct 29, 2024
@pablogsal pablogsal enabled auto-merge (squash) October 29, 2024 23:06
@pablogsal pablogsal merged commit 9dfef4e into python:main Oct 29, 2024
46 checks passed
@pablogsal pablogsal deleted the gh-125588 branch October 29, 2024 23:40
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@pablogsal @picnixz
pythongh-125588: Teach the python PEG generator the new f-string toke…
2b31cb7 
…ns (python#125589)

Signed-off-by: Pablo Galindo <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@pablogsal @ebonnal
pythongh-125588: Teach the python PEG generator the new f-string toke…
c7212ca 
…ns (python#125589)

Signed-off-by: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal @Eclips4 @AlexWaygood