Skip to content

gh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check #125612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2024
Merged

gh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check #125612

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a126a8
gh-125610: Fix `STORE_ATTR_INSTANCE_VALUE` specialization check
colesbury Oct 16, 2024
9aa12bd
Update Python/specialize.c
colesbury Oct 24, 2024
1e9e3a5
Merge branch 'main' into gh-125610-STORE_ATTR_INSTANCE_VALUE
colesbury Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,10 @@ specialize_dict_access(
return 0;
}
_PyAttrCache *cache = (_PyAttrCache *)(instr + 1);
if (type->tp_flags & Py_TPFLAGS_INLINE_VALUES && _PyObject_InlineValues(owner)->valid) {
if (type->tp_flags & Py_TPFLAGS_INLINE_VALUES &&
_PyObject_InlineValues(owner)->valid &&
(base_op == LOAD_ATTR || _PyObject_GetManagedDict(owner) == NULL))
{
PyDictKeysObject *keys = ((PyHeapTypeObject *)type)->ht_cached_keys;
assert(PyUnicode_CheckExact(name));
Py_ssize_t index = _PyDictKeys_StringLookup(keys, name);
Expand Down
Loading