Skip to content

Conversation

@BosieIonut
Copy link

@BosieIonut BosieIonut commented Oct 17, 2024

When you are trying to connect to a domain with the dot at the end (ex: mta5.am0.yahoodns.net. instead of mta5.am0.yahoodns.net) the smtp connection works just fine but starttls() will raise an handshake execption.

When you are trying to connect to a domain with the dot at the end the smtp connection works just fine but starttls() will raise an handshake execption.
@BosieIonut BosieIonut requested a review from a team as a code owner October 17, 2024 20:36
@ghost
Copy link

ghost commented Oct 17, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 17, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bitdancer
Copy link
Member

I would like to understand why this produces an error. A domain name with a trailing '.' has a meaning: don't try to resolve this name with a local extension (see /etc/resolve.conf 'search' control). So passing the trailing dot through is the correct behavior, and I'd like to know why starttls is failing. Is this a bug in (some implementations of?) starttls? An RFC disagreement (I hope not)?

@skirpichev
Copy link
Contributor

Thanks for your contribution, but it's no-go as is.

This worth an issue (please open) and a changelog entry. Also, please do pr wrt the main branch, not against the maintenance branch. See also https://devguide.python.org/

@skirpichev skirpichev closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants