Skip to content

gh-125682: Python implementation of json.loads() accepts non-ascii digits #125687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2024
Merged

gh-125682: Python implementation of json.loads() accepts non-ascii digits #125687

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
940c020
Reject unicode digits for Python implementation of json.loads()
nineteendo Oct 18, 2024
d9da606
Add tests
nineteendo Oct 18, 2024
e14ea84
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 18, 2024
10923b2
Apply suggestions from code review
nineteendo Oct 18, 2024
905ab94
Link to github issue
nineteendo Oct 18, 2024
9b50c09
Update Misc/NEWS.d/next/Library/2024-10-18-09-51-29.gh-issue-125682.v…
nineteendo Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/json/scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
__all__ = ['make_scanner']

NUMBER_RE = re.compile(
r'(-?(?:0|[1-9]\d*))(\.\d+)?([eE][-+]?\d+)?',
r'(-?(?:0|[1-9][0-9]*))(\.[0-9]+)?([eE][-+]?[0-9]+)?',
(re.VERBOSE | re.MULTILINE | re.DOTALL))

def py_make_scanner(context):
Expand Down
6 changes: 6 additions & 0 deletions Lib/test/test_json/test_decode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ def test_float(self):
self.assertIsInstance(rval, float)
self.assertEqual(rval, 1.0)

def test_nonascii_digits_rejected(self):
# JSON specifies only ascii digits, see gh-125687
for num in ["1\uff10", "0.\uff10", "0e\uff10"]:
with self.assertRaises(self.JSONDecodeError):
self.loads(num)

def test_bytes(self):
self.assertEqual(self.loads(b"1"), 1)

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-10-18-09-51-29.gh-issue-125682.vsj4cU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Reject non-ASCII digits in the Python implementation of :func:`json.loads`
conforming to the json specification.
Loading