Skip to content

Removed unnecessary call to reversed in for loop #125690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Removed unnecessary call to reversed in for loop #125690

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b26422
Removed unnecessary call to reversed in for loop
RScrusoe Oct 18, 2024
de175f7
Update Lib/random.py to follow the lint conventions
RScrusoe Oct 18, 2024
a897ac0
Merge branch 'main' into random-shuffle-optimization
RScrusoe Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/random.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,8 @@ def shuffle(self, x):
"""Shuffle list x in place, and return None."""

randbelow = self._randbelow
for i in reversed(range(1, len(x))):
# Iterate over the list x in reverse order
for i in range(len(x)-1,0,-1):
# pick an element in x[:i+1] with which to exchange x[i]
j = randbelow(i + 1)
x[i], x[j] = x[j], x[i]
Expand Down
Loading