Skip to content

Conversation

@drewarnett
Copy link

@drewarnett drewarnett commented Oct 23, 2024

The tutorial classes chapter multiple inheritance section described MRO as depth first. That was the case for the old classic classes in Python2.


📚 Documentation preview 📚: https://cpython-previews--125906.org.readthedocs.build/

The tutorial classes chapter multiple inheritance section
described MRO as depth first.  That was the case for the old
classic classes in Python2.
@ghost
Copy link

ghost commented Oct 23, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland changed the title gh-125904: fix MRO summary discription in tutorial gh-125904: Fix MRO summary description in tutorial Nov 5, 2024

For most purposes, in the simplest cases, you can think of the search for
attributes inherited from a parent class as depth-first, left-to-right, not
attributes inherited from a parent class as breadth-first, left-to-right, not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the following example in L643-L645?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the following example in L643-L645?

Good point. Have been thinking about this more. Maybe should cancel the PR and discuss this portion of the docs further in the issue ticket #125904?

@drewarnett
Copy link
Author

Cancelling this request. Leaving issue #125904 open to consider further how to update this section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants