Skip to content

Conversation

@rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Oct 25, 2024

@ZeroIntensity
Copy link
Member

I think this looks fine, but I'm assuming that Eric wanted something a bit more in depth judging by the original issue, so I'm going to refrain from approving for now.

@rruuaanng
Copy link
Contributor Author

Actually, the focus is on highlighting the differences between Python threads and other threads. This clearly illustrates the unique aspects of Python daemon threads, and I believe Eric won’t have any objections to this.

@ZeroIntensity
Copy link
Member

Well, IIUC, part the motivation was to document some of the concerns about daemon threads as well. This sort of tells you what to do with them, but not what's wrong with them.

@rruuaanng
Copy link
Contributor Author

So in the description, I described that join should be used to solve it.

@ZeroIntensity
Copy link
Member

That's not that useful though, because the whole point of a daemon thread is that you don't want it to join.

@erlend-aasland erlend-aasland marked this pull request as draft November 5, 2024 10:56
@rruuaanng
Copy link
Contributor Author

That's not that useful though, because the whole point of a daemon thread is that you don't want it to join

I'm not sure if the new change is appropriate, but it seems to avoid emphasizing the need to call .join(). But, right, daemon threads generally don't require waiting for their completion, but it still allows the user to call it on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants