Skip to content

gh-125911: Call for combine_symbol_mask on the initial trampoline for a trace #125973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

gh-125911: Call for combine_symbol_mask on the initial trampoline for a trace #125973

merged 1 commit into from
Oct 25, 2024

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Oct 25, 2024 •
edited by bedevere-app bot
Loading

@Zheaoli Zheaoli requested a review from brandtbucher as a code owner October 25, 2024 10:35
@bedevere-app bedevere-app bot mentioned this pull request Oct 25, 2024
Closed
@brandtbucher brandtbucher self-assigned this Oct 25, 2024
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels Oct 25, 2024
brandtbucher
brandtbucher approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @savannahostrowski, pulling this into your PR should fix the issue.

@brandtbucher brandtbucher enabled auto-merge (squash) October 25, 2024 15:38
@brandtbucher brandtbucher merged commit 7f6e884 into python:main Oct 25, 2024
63 checks passed
@Zheaoli Zheaoli deleted the manjusaka/fix-combine_symbol_mask-jit branch October 25, 2024 16:03
@savannahostrowski
Copy link
Member

savannahostrowski commented Oct 25, 2024 •
edited
Loading

Thanks @Zheaoli - confirming that this did fix the failing CI job on #125499

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@Zheaoli @ebonnal
pythonGH-125911: Call combine_symbol_mask on the initial trampoline o…
490b22c 
…f a trace (pythonGH-125973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news topic-JIT type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zheaoli @savannahostrowski @brandtbucher