Skip to content

gh-126028: Add more tests for msvcrt module #126029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gh-126028: Add more tests for msvcrt module #126029

Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
71d7cc7
Add more tests for msvcrt module
aisk Oct 27, 2024
e14193d
Fix typos
aisk Oct 27, 2024
f76b823
Fix another two typos
aisk Oct 27, 2024
b0f2acc
Improve test
aisk Oct 28, 2024
a3f1546
Improve other tests
aisk Oct 28, 2024
13d4345
Check the result in some tests
aisk Oct 28, 2024
fee526e
Merge branch 'main' into msvcrt-more-tests
serhiy-storchaka Jul 13, 2025
c11647c
Update test_GetErrorCode
aisk Jul 16, 2025
54ae00e
Improve test_set_error_mode
aisk Jul 16, 2025
90b904a
Update test CrtSetReportXxx
aisk Jul 16, 2025
79b1e6e
Check if the old is equal to returned in some cases
aisk Jul 17, 2025
d70b3ce
Remove some redundant type check
aisk Jul 17, 2025
c5c4005
Test with extrem values
aisk Jul 17, 2025
62a8389
Fix test
aisk Jul 17, 2025
2d794f3
Fix test_GetErrorMode
aisk Jul 17, 2025
2fbd2e8
Fix test_SetErrorMode
aisk Jul 17, 2025
c3726e1
Fix test_SetErrorMode
aisk Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 45 additions & 1 deletion Lib/test/test_msvcrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import unittest
from textwrap import dedent

from test.support import os_helper, requires_resource
from test.support import os_helper, requires_resource, Py_DEBUG
from test.support.os_helper import TESTFN, TESTFN_ASCII

if sys.platform != "win32":
Expand Down Expand Up @@ -115,6 +115,50 @@ def test_heap_min(self):
except OSError:
pass

def test_GetErrorMode(self):
msvcrt.GetErrorMode()

def test_SetErrorMode(self):
old = msvcrt.GetErrorMode()
self.addCleanup(msvcrt.SetErrorMode, old)

returned = msvcrt.SetErrorMode(0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe test it also with non-zero value, and also with out-of-range values -1 and 2**32? If this is possible (if the test does not crash or hangs).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function SetErrorMode have weird behaviors and it behaves different in the test case or in a standalone test script, it sometimes returns different mode compare to the one set. I'm still try to figure it out and will update it tomorrow, thank you for the review!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out the case of SetErrorMode and found that it's actually not set the value to current, but set the bit flags on it. Currently made the test workable, but still have some concerns about it.

Added some details as a separate comment blow.

self.assertIs(type(returned), int)
self.assertEqual(old, returned)

@unittest.skipUnless(Py_DEBUG, "only available under debug build")
def test_set_error_mode(self):
old = msvcrt.set_error_mode(msvcrt.REPORT_ERRMODE)
self.addCleanup(msvcrt.set_error_mode, old)

returned = msvcrt.set_error_mode(msvcrt.OUT_TO_STDERR)
self.assertIs(type(returned), int)
self.assertNotEqual(returned, -1)
self.assertEqual(old, returned)

@unittest.skipUnless(Py_DEBUG, "only available under debug build")
def test_CrtSetReportMode(self):
old = msvcrt.CrtSetReportMode(msvcrt.CRT_WARN,
msvcrt.CRTDBG_REPORT_MODE)
self.addCleanup(msvcrt.CrtSetReportMode, msvcrt.CRT_WARN, old)

returned = msvcrt.CrtSetReportMode(msvcrt.CRT_WARN,
msvcrt.CRTDBG_MODE_DEBUG)
self.assertIs(type(returned), int)
self.assertNotEqual(returned, -1)
self.assertEqual(old, returned)

@unittest.skipUnless(Py_DEBUG, "only available under debug build")
def test_CrtSetReportFile(self):
old = msvcrt.CrtSetReportFile(msvcrt.CRT_WARN,
msvcrt.CRTDBG_REPORT_FILE)
self.addCleanup(msvcrt.CrtSetReportFile, msvcrt.CRT_WARN, old)

returned = msvcrt.CrtSetReportFile(msvcrt.CRT_WARN,
msvcrt.CRTDBG_FILE_STDOUT)
self.assertIs(type(returned), int)
self.assertEqual(old, returned)


if __name__ == "__main__":
unittest.main()
Loading