-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-126019 Fix inspect.getsource for classes created in PyREPL #126032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devdanzin
wants to merge
11
commits into
python:main
Choose a base branch
from
devdanzin:fix_repl_inspect_getsource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9b1369e
Fix inspect.getsource for classes created in PyREPL.
devdanzin 5eafc69
Fix test_inspect_getsource.
devdanzin cc16cac
Add test_class_defined_in_pyrepl to test_inspect.TestBuggyCases.
devdanzin c76fb0e
📜🤖 Added by blurb_it.
blurb-it[bot] b3b9cb6
Merge branch 'main' into fix_repl_inspect_getsource
devdanzin 46b88d6
Undo changes to inspect.
devdanzin e3e82b3
Remove __file__ attribute from __main__ when PyREPL starts.
devdanzin cc19746
Fix test_inspect_keeps_globals_from_inspected_module.
devdanzin 73d66c1
Update NEWS entry for PR.
devdanzin 2c09d05
Fix NEWS entry for PR.
devdanzin 7448a6f
Remove outdated comment.
devdanzin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2024-10-27-11-46-13.gh-issue-126019.I_GHhZ.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Remove the ``__file__`` attribute from the ``__main__`` namespace created by | ||
| PyREPL, to avoid :func:`inspect.getsource` from fetching unrelated source | ||
| code for classes defined in the REPL. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that testing whether
inspect.getsourceworks on other objects (functions, methods, traceback, frames) is worthwhile, but I'm not sure if it should be done in this PR. So, I'd be fine with doing it in a follow-up