Skip to content

gh-126096: Use a thread-local freelist for thread states #126097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

gh-126096: Use a thread-local freelist for thread states #126097

wants to merge 7 commits into from

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Oct 28, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 28, 2024
Closed
devdanzin
devdanzin reviewed Oct 28, 2024
View reviewed changes
@ZeroIntensity ZeroIntensity marked this pull request as draft October 30, 2024 12:36
@ZeroIntensity
Copy link
Member Author

I'm abandoning this proposal. I wasn't aware that thread states could get freed outside of the thread that they were created in, so this leaks in those cases.

@ZeroIntensity ZeroIntensity deleted the tstate-freelist branch October 31, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devdanzin devdanzin devdanzin left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

topic-subinterpreters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity @devdanzin