Skip to content

gh-126106: Fix NULL possible dereference in Modules/_ssl.c #126111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2024
Merged

gh-126106: Fix NULL possible dereference in Modules/_ssl.c #126111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
496c94c
gh-126106: Fix `NULL` possible derefrence in `Modules/_ssl.c`
sobolevn Oct 29, 2024
cfcbbe4
Update Misc/NEWS.d/next/Library/2024-10-29-10-58-52.gh-issue-126106.r…
sobolevn Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-10-29-10-58-52.gh-issue-126106.rlF798.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixes ``NULL`` possible dereference in ``Modules/_ssl.c``.
6 changes: 3 additions & 3 deletions Modules/_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5424,14 +5424,14 @@ PySSLSession_dealloc(PySSLSession *self)
static PyObject *
PySSLSession_richcompare(PyObject *left, PyObject *right, int op)
{
int result;
PyTypeObject *sesstype = ((PySSLSession*)left)->ctx->state->PySSLSession_Type;

if (left == NULL || right == NULL) {
PyErr_BadInternalCall();
return NULL;
}

int result;
PyTypeObject *sesstype = ((PySSLSession*)left)->ctx->state->PySSLSession_Type;

if (!Py_IS_TYPE(left, sesstype) || !Py_IS_TYPE(right, sesstype)) {
Py_RETURN_NOTIMPLEMENTED;
}
Expand Down
Loading