Skip to content

gh-126146: Remove __cmp__ method from tests #126147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024
Merged

gh-126146: Remove __cmp__ method from tests #126147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/test/test_descr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3239,8 +3239,6 @@ class classic:
class C(base):
def __init__(self, value):
self.value = int(value)
def __cmp__(self_, other):
self.fail("shouldn't call __cmp__")
def __eq__(self, other):
if isinstance(other, C):
return self.value == other.value
Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_richcmp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ def __gt__(self, other):
def __ge__(self, other):
return self.x >= other

def __cmp__(self, other):
raise support.TestFailed("Number.__cmp__() should not be called")

def __repr__(self):
return "Number(%r)" % (self.x, )

Expand All @@ -53,9 +50,6 @@ def __setitem__(self, i, v):
def __bool__(self):
raise TypeError("Vectors cannot be used in Boolean contexts")

def __cmp__(self, other):
raise support.TestFailed("Vector.__cmp__() should not be called")

def __repr__(self):
return "Vector(%r)" % (self.data, )

Expand Down
Loading