Skip to content

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Oct 31, 2024

I believe the proposed modification lets the user know earlier if the module is useful to them and that shelve may help him/her if the dbm module is not enough.


📚 Documentation preview 📚: https://cpython-previews--126218.org.readthedocs.build/

@serhiy-storchaka
Copy link
Member

@rhettinger, do you like to look at this?

@erlend-aasland
Copy link
Contributor

There is already a .. seealso that points to shelve. If we are to make any changes, consider instead to make that reference more prominent, for example by moving it up to the introduction. IMO, that should be sufficient.

@andresdelfino
Copy link
Contributor Author

There is already a .. seealso that points to shelve. If we are to make any changes, consider instead to make that reference more prominent, for example by moving it up to the introduction. IMO, that should be sufficient.

Hmmm, the PR does also make that change. Perhaps I'm not understanding you correctly?

@erlend-aasland
Copy link
Contributor

Hmmm, the PR does also make that change. Perhaps I'm not understanding you correctly?

Sorry, my bad; I misread the PR to just add a new .. seealso. Yes, this particular change is fine with me.

erlend-aasland
erlend-aasland previously approved these changes Nov 11, 2024
@erlend-aasland erlend-aasland changed the title Explain what a DBM database is and point to shelve earlier Docs: promote the shelve module in the dbm docs introduction Nov 11, 2024
@erlend-aasland erlend-aasland dismissed their stale review November 11, 2024 21:41

I think some amendments are needed

@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@andresdelfino
Copy link
Contributor Author

Should I close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip issue skip news

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants