Skip to content

gh-125522: Remove bare except in test_zlib.test_flushes #126321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 2, 2024
Merged

gh-125522: Remove bare except in test_zlib.test_flushes #126321

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bbd858
gh-125522: Fix bare except in test_zlib.test_flushes
simple-is-great Nov 2, 2024
97624f6
Merge branch 'main' into test_zlib
simple-is-great Nov 2, 2024
34c797c
Address code review
simple-is-great Nov 2, 2024
e016be4
address code review: fixed whitespaces and format
simple-is-great Nov 2, 2024
d0a8af5
Update Lib/test/test_zlib.py
simple-is-great Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions Lib/test/test_zlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,20 +505,16 @@ def test_flushes(self):

for sync in sync_opt:
for level in range(10):
try:
with self.subTest(sync=sync, level=level):
obj = zlib.compressobj( level )
a = obj.compress( data[:3000] )
b = obj.flush( sync )
c = obj.compress( data[3000:] )
d = obj.flush()
except:
print("Error for flush mode={}, level={}"
.format(sync, level))
raise
self.assertEqual(zlib.decompress(b''.join([a,b,c,d])),
data, ("Decompress failed: flush "
"mode=%i, level=%i") % (sync, level))
del obj
self.assertEqual(zlib.decompress(b''.join([a,b,c,d])),
data, ("Decompress failed: flush "
"mode=%i, level=%i") % (sync, level))
del obj

@unittest.skipUnless(hasattr(zlib, 'Z_SYNC_FLUSH'),
'requires zlib.Z_SYNC_FLUSH')
Expand Down
Loading