Skip to content

gh-126390: Support for preserving order of options and nonoption arguments in gnu_getopt() #126393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

gh-126390: Support for preserving order of options and nonoption arguments in gnu_getopt() #126393

merged 2 commits into from
Nov 13, 2024

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 4, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 4, 2024
Closed
gpshead
gpshead reviewed Nov 6, 2024
View reviewed changes
@serhiy-storchaka
Copy link
Member Author

This PR should be merged after #126375 (where that typo was already fixed.).

@erlend-aasland
Copy link
Contributor

This PR should be merged after #126375 (where that typo was already fixed.).

So let's mark it as a draft to make that more obvious.

@serhiy-storchaka serhiy-storchaka marked this pull request as draft November 6, 2024 22:05
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review November 11, 2024 16:39
@serhiy-storchaka
Copy link
Member Author

Now this PR only contains the changes for #126390.

serhiy-storchaka
serhiy-storchaka commented Nov 11, 2024
View reviewed changes
@gpshead gpshead added the type-feature A feature request or enhancement label Nov 13, 2024
@gpshead gpshead mentioned this pull request Nov 13, 2024
Merged
gpshead
gpshead approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature!

@serhiy-storchaka
Copy link
Member Author

Thank you for your review @gpshead.

@serhiy-storchaka serhiy-storchaka merged commit 35010b8 into python:main Nov 13, 2024
43 of 44 checks passed
@serhiy-storchaka serhiy-storchaka deleted the getopt-return-in-order branch November 13, 2024 20:50
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 13, 2024
Closed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@serhiy-storchaka @picnixz
pythongh-126390: Support for preserving order of options and nonoptio…
6f3cc66 
…n arguments in gnu_getopt() (pythonGH-126393)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@serhiy-storchaka @ebonnal
pythongh-126390: Support for preserving order of options and nonoptio…
31a0795 
…n arguments in gnu_getopt() (pythonGH-126393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @erlend-aasland @gpshead