Skip to content

gh-126417: Register multiprocessing proxy types to an appropriate collections.abc class #126419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2024
Merged

gh-126417: Register multiprocessing proxy types to an appropriate collections.abc class #126419

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3c4c52
register proxy types in multiprocessing.manager to collections ABCs
tungol Nov 5, 2024
a76d63b
name multiprocessing.managers._BaseDictProxy consistently
tungol Nov 5, 2024
d523fd1
Update Misc/NEWS.d/next/Library/2024-11-04-16-40-02.gh-issue-126417.O…
tungol Nov 5, 2024
a2b7fd6
add tests
tungol Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/multiprocessing/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import threading
import signal
import array
import collections.abc
import queue
import time
import types
Expand Down Expand Up @@ -1167,8 +1168,9 @@ def __imul__(self, value):

__class_getitem__ = classmethod(types.GenericAlias)

collections.abc.MutableSequence.register(BaseListProxy)

_BaseDictProxy = MakeProxyType('DictProxy', (
_BaseDictProxy = MakeProxyType('_BaseDictProxy', (
'__contains__', '__delitem__', '__getitem__', '__ior__', '__iter__',
'__len__', '__or__', '__reversed__', '__ror__',
'__setitem__', 'clear', 'copy', 'fromkeys', 'get', 'items',
Expand All @@ -1184,6 +1186,8 @@ def __ior__(self, value):

__class_getitem__ = classmethod(types.GenericAlias)

collections.abc.MutableMapping.register(_BaseDictProxy)

ArrayProxy = MakeProxyType('ArrayProxy', (
'__len__', '__getitem__', '__setitem__'
))
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,6 +1273,7 @@ Emily Morehouse
Derek Morr
James A Morrison
Martin Morrison
Stephen Morton
Derek McTavish Mounce
Alessandro Moura
Pablo Mouzo
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2024-11-04-16-40-02.gh-issue-126417.OWPqn0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Register the ``DictProxy`` and ``ListProxy`` types in
:mod:`multiprocessing.managers` to collections.abc.MutableMapping and
collections.abc.MutableSequence, respectively.
Loading