Skip to content

gh-116772: Cache getenv result in optimizer.c to reduce calls #126439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-116772: Cache getenv result in optimizer.c to reduce calls #126439

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
537431e
Cache getenv result in optimizer.c to reduce calls
Wulian233 Nov 5, 2024
5c59297
Update optimizer.c
Wulian233 Apr 29, 2025
f25a357
try fix
Wulian233 Apr 29, 2025
8dace6c
Merge branch 'python:main' into getenv
Wulian233 Apr 29, 2025
acad35f
not safe WIP
Wulian233 Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-11-05-19-44-32.gh-issue-116772.jC4dMr.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Cache ``getenv`` result in optimizer.c to reduce redundant calls during
optimization
17 changes: 15 additions & 2 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,9 @@ int effective_trace_length(_PyUOpInstruction *buffer, int length)
}
#endif

static int uop_optimize_initialized = 0;
static int uop_optimize_flag = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't thread safe or subinterpreter safe. You might want to store the value in a PyThreadState / PyInterpreterState in pylifecycle.c instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a try, but it didn’t work out in the end. I guess I don’t have enough experience yet. I'm really sorry, I might not be able to handle this on my own. Maybe someone else could take it, or maybe you could help improve what I have so far :(


static int
uop_optimize(
_PyOptimizerObject *self,
Expand All @@ -1245,8 +1248,18 @@ uop_optimize(
}
assert(length < UOP_MAX_TRACE_LENGTH);
OPT_STAT_INC(traces_created);
char *env_var = Py_GETENV("PYTHON_UOPS_OPTIMIZE");
if (env_var == NULL || *env_var == '\0' || *env_var > '0') {

if (!uop_optimize_initialized) {
char *env_var = Py_GETENV("PYTHON_UOPS_OPTIMIZE");
if (env_var == NULL || *env_var == '\0' || *env_var > '0') {
uop_optimize_flag = 1;
} else {
uop_optimize_flag = 0;
}
uop_optimize_initialized = 1;
}

if (uop_optimize_flag) {
length = _Py_uop_analyze_and_optimize(frame, buffer,
length,
curr_stackentries, &dependencies);
Expand Down
Loading