Skip to content

gh-126469: remove unnecessary error-checking branch in lexer.c #126473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 1, 2025
Merged

gh-126469: remove unnecessary error-checking branch in lexer.c #126473

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02eae55
fix a error in lexer.c
qqwqqw689 Nov 6, 2024
e0f9ba8
Update Parser/lexer/lexer.c
qqwqqw689 Nov 6, 2024
54cc4bc
Update lexer.c
qqwqqw689 Nov 6, 2024
ade12b9
Update Parser/lexer/lexer.c
pablogsal Jan 1, 2025
c162e7e
Merge branch 'main' into main
picnixz Jan 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Parser/lexer/lexer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,11 @@ verify_identifier(struct tok_state *tok)
}
return 0;
}

Py_ssize_t invalid = _PyUnicode_ScanIdentifier(s);
if (invalid < 0) {
Py_ssize_t len = PyUnicode_GET_LENGTH(s);

if (invalid < len) {
Py_DECREF(s);
tok->done = E_ERROR;
return 0;
Expand Down
Loading