Skip to content

gh-58749: Removes the erroneous explanation regarding the restrictions of the global statement #126523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2024
Merged

gh-58749: Removes the erroneous explanation regarding the restrictions of the global statement #126523

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83a13b8
Removes erroneous explanation of the `global` about its restrictions;…
bombs-kim Nov 7, 2024
f37b6d9
Change test module description to reflect the new tests
bombs-kim Nov 11, 2024
ec10a82
With the change in the documentation, the previous warning no longer …
bombs-kim Nov 11, 2024
17caf99
Adds name to ACKS
bombs-kim Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions Doc/reference/simple_stmts.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,19 +966,14 @@ The :keyword:`!global` statement
.. productionlist:: python-grammar
global_stmt: "global" `identifier` ("," `identifier`)*

The :keyword:`global` statement is a declaration which holds for the entire
current code block. It means that the listed identifiers are to be interpreted
as globals. It would be impossible to assign to a global variable without
The :keyword:`global` causes the listed identifiers to be interpreted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads The global, so is missing a noun: The global keyword

Copy link
Contributor Author

@bombs-kim bombs-kim Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @merwok , thanks for the correction. I opened #126720 that reflects this feedback and handles some more mishaps.

as globals. It would be impossible to assign to a global variable without
:keyword:`!global`, although free variables may refer to globals without being
declared global.

Names listed in a :keyword:`global` statement must not be used in the same code
block textually preceding that :keyword:`!global` statement.

Names listed in a :keyword:`global` statement must not be defined as formal
parameters, or as targets in :keyword:`with` statements or :keyword:`except` clauses, or in a :keyword:`for` target list, :keyword:`class`
definition, function definition, :keyword:`import` statement, or
:term:`variable annotations <variable annotation>`.
The global statement applies to the entire scope of a function or
class body. A :exc:`SyntaxError` is raised if a variable is used or
assigned to prior to its global declaration in the scope.

.. impl-detail::

Expand Down
Loading