gh-126529: Update devguide links to relative filenames in InternalDocs/parser.md and InternalDocs/compiler.md #126530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @valerii-chirkov for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @valerii-chirkov and @vstinner, I could not cleanly backport this to |
|
Merged, thanks for your contribution! |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…nalDocs (python#126530) Update devguide links to relative filenames in InternalDocs/parser.md and InternalDocs/compiler.md.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…nalDocs (python#126530) Update devguide links to relative filenames in InternalDocs/parser.md and InternalDocs/compiler.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned it for parsed.md in this Issue #126509
Closed in this PR #126510
Found the same issue in compiler.md, and searched through InternalDocs for any other appearance of devguide links, found nothing except two in compiler.md ("Guide to the parser" and "Changing CPython’s grammar").
Also mentioned that in this PR #126510 I added a relative link as
./, but in InternalDocs only filename as a path is used, so changed it from./changing_grammar.mdtochanging_grammar.md