Skip to content

gh-112936: Fix IDLE: no Shell menu item in single-process mode #126598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025
Merged

gh-112936: Fix IDLE: no Shell menu item in single-process mode #126598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ba265c
fix: restore menu "Shell", and disable two submenus when using "-n"
Xiaokang2022 Nov 8, 2024
7467b24
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 8, 2024
a3e093f
feat: add a comment for clarity.
Xiaokang2022 May 2, 2025
579cf1c
Merge branch 'main' into fix-idle-menu
Xiaokang2022 May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Lib/idlelib/pyshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,10 +877,9 @@ class PyShell(OutputWindow):
from idlelib.sidebar import ShellSidebar

def __init__(self, flist=None):
if use_subprocess:
ms = self.menu_specs
if ms[2][0] != "shell":
ms.insert(2, ("shell", "She_ll"))
ms = self.menu_specs
if ms[2][0] != "shell":
ms.insert(2, ("shell", "She_ll"))
self.interp = ModifiedInterpreter(self)
if flist is None:
root = Tk()
Expand Down Expand Up @@ -954,6 +953,11 @@ def __init__(self, flist=None):
self.text.insert = self.per.top.insert
self.per.insertfilter(UserInputTaggingDelegator())

if not use_subprocess:
# Menu options "View Last Restart" and "Restart Shell" are disabled
self.update_menu_state("shell", 0, "disabled")
self.update_menu_state("shell", 1, "disabled")

def ResetFont(self):
super().ResetFont()

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2024-11-08-18-07-13.gh-issue-112936.1Q2RcP.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix IDLE: no Shell menu item in single-process mode.
Loading