Skip to content

Conversation

@hartwork
Copy link
Contributor

@hartwork hartwork commented Nov 9, 2024

@hartwork hartwork force-pushed the issue-126624-expose-new-expat-2-6-4-error-code branch from 346217e to 090f254 Compare November 9, 2024 20:34
@ZeroIntensity
Copy link
Member

For the future, you don't need to force push anything--we squash merge at the end.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc @picnixz @Eclips4

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@hartwork
Copy link
Contributor Author

Ready to merge?

@ZeroIntensity
Copy link
Member

ZeroIntensity commented Nov 24, 2024

I think so, but Kirill might want a second core dev approval.

@Eclips4 Eclips4 merged commit 8e48a6e into python:main Jan 2, 2025
43 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
… >=2.6.4 (python#126625)

Expose error code ``XML_ERROR_NOT_STARTED`` in `xml.parsers.expat.errors` which was
introduced in Expat 2.6.4.


Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants