Skip test in test_socket.py if there is no sys.getrefcount, like on pypy #126640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbolz
added a commit
to pypy/pypy
that referenced
this pull request
Nov 10, 2024
also submitted to cpy: python/cpython#126640
Eclips4
approved these changes
Nov 10, 2024
Eclips4
added
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 10, 2024
…honGH-126640) Skip `testMakefileCloseSocketDestroy` test if `sys.getrefcount` isn't available. This is necessary for PyPy and other Python implementations that do not have `sys.getrefcount`. (cherry picked from commit 0f6bb28) Co-authored-by: CF Bolz-Tereick <[email protected]>
|
GH-126645 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 10, 2024
…honGH-126640) Skip `testMakefileCloseSocketDestroy` test if `sys.getrefcount` isn't available. This is necessary for PyPy and other Python implementations that do not have `sys.getrefcount`. (cherry picked from commit 0f6bb28) Co-authored-by: CF Bolz-Tereick <[email protected]>
|
GH-126646 is a backport of this pull request to the 3.12 branch. |
Eclips4
pushed a commit
that referenced
this pull request
Nov 10, 2024
…le (GH-126640) (#126646) Skip test in test_socket.py if `sys.getrefcount` isn't available (GH-126640) Skip `testMakefileCloseSocketDestroy` test if `sys.getrefcount` isn't available. This is necessary for PyPy and other Python implementations that do not have `sys.getrefcount`. (cherry picked from commit 0f6bb28) Co-authored-by: CF Bolz-Tereick <[email protected]>
Eclips4
pushed a commit
that referenced
this pull request
Nov 10, 2024
…le (GH-126640) (#126645) Skip test in test_socket.py if `sys.getrefcount` isn't available (GH-126640) Skip `testMakefileCloseSocketDestroy` test if `sys.getrefcount` isn't available. This is necessary for PyPy and other Python implementations that do not have `sys.getrefcount`. (cherry picked from commit 0f6bb28) Co-authored-by: CF Bolz-Tereick <[email protected]>
|
thank you, @Eclips4! |
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…hon#126640) Skip `testMakefileCloseSocketDestroy` test if `sys.getrefcount` isn't available. This is necessary for PyPy and other Python implementations that do not have `sys.getrefcount`.
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…hon#126640) Skip `testMakefileCloseSocketDestroy` test if `sys.getrefcount` isn't available. This is necessary for PyPy and other Python implementations that do not have `sys.getrefcount`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is already done for
testRefCountGetNameInfoin the same file. on pypy and other non-cpython implementations there is nogetrefcount.