Skip to content

Conversation

@rhansen
Copy link
Contributor

@rhansen rhansen commented Nov 11, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 11, 2024
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ZeroIntensity
Copy link
Member

@Eclips4 I think you're fine to merge this. I'm quite certain this change is correct, and I really doubt that Eric would disagree. For precedent:

PyStatus status = Py_NewInterpreterFromConfig(&substate, &config);
if (PyStatus_Exception(status)) {

@Eclips4 Eclips4 merged commit e3038e9 into python:main Nov 23, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @rhansen for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 23, 2024

GH-127201 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2024
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 23, 2024

GH-127202 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 23, 2024
Eclips4 pushed a commit that referenced this pull request Nov 23, 2024
…-126667) (#127201)

Doc: C API: Fix `Py_NewInterpreterFromConfig` example code (GH-126667)
(cherry picked from commit e3038e9)

Co-authored-by: Richard Hansen <[email protected]>
Eclips4 pushed a commit that referenced this pull request Nov 23, 2024
…-126667) (#127202)

Doc: C API: Fix `Py_NewInterpreterFromConfig` example code (GH-126667)
(cherry picked from commit e3038e9)

Co-authored-by: Richard Hansen <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants