gh-126639: Add ResourceWarning to NamedTemporaryFile #126677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kumaraditya303 merged 11 commits into python:main from graingert:add-warning-to-named-temporary-file

Dec 18, 2024

Contributor

graingert commented Nov 11, 2024 •

edited by bedevere-app bot

Loading

Issue: NamedTemporaryFile doesn't issue a ResourceWarning when left unclosed on POSIX #126639

bedevere-app bot mentioned this pull request

NamedTemporaryFile doesn't issue a ResourceWarning when left unclosed on POSIX #126639

Closed

graingert and others added 2 commits

November 11, 2024 08:05


          pythongh-126639: Add ResourceWarning to NamedTemporaryFile

600ffe1


          📜🤖 Added by blurb_it.

4932cd3

graingert force-pushed the add-warning-to-named-temporary-file branch from ae4b87b to 4932cd3 Compare

November 11, 2024 08:05

Contributor Author

graingert commented Nov 11, 2024

Ok this doesn't seem to break anything! I'll need to add a test though

graingert marked this pull request as ready for review

November 11, 2024 08:20

bedevere-app bot added the awaiting review label

graingert added 2 commits

November 11, 2024 15:39


          test that NamedTemporaryFile issues a ResourceWarning

136ce71


          Merge branch 'main' into add-warning-to-named-temporary-file

2ad613b

graingert commented

View reviewed changes

Misc/NEWS.d/next/Library/2024-11-11-07-56-03.gh-issue-126639.AmVSt-.rst Outdated Show resolved Hide resolved


          Update Misc/NEWS.d/next/Library/2024-11-11-07-56-03.gh-issue-126639.A…

b6e91c1

…mVSt-.rst

graingert commented

View reviewed changes

Lib/test/test_tempfile.py Outdated Show resolved Hide resolved


          Update Lib/test/test_tempfile.py

9498d74

graingert commented

View reviewed changes

Lib/tempfile.py Outdated Show resolved Hide resolved


          Update Lib/tempfile.py

7db921a

graingert commented

View reviewed changes

Misc/NEWS.d/next/Library/2024-11-11-07-56-03.gh-issue-126639.AmVSt-.rst Outdated Show resolved Hide resolved


          Update Misc/NEWS.d/next/Library/2024-11-11-07-56-03.gh-issue-126639.A…

dcde1d6

…mVSt-.rst

graingert commented

View reviewed changes

Lib/test/test_tempfile.py Show resolved Hide resolved

Contributor

nineteendo commented Nov 11, 2024 •

edited

Loading

TIP: You can add suggestions to batch from the files tab to apply multiple suggestions in a single commit.

Contributor Author

graingert commented Nov 11, 2024

TIP: You can add suggestions to batch from the files tab to apply multiple suggestions in a single commit.

Oh yeah I know, but I found the issues with some time apart so they didn't exist together to be batched

asvetlov approved these changes

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels


          Merge branch 'main' into add-warning-to-named-temporary-file

91046f5

kumaraditya303 approved these changes

View reviewed changes


          Merge branch 'main' into add-warning-to-named-temporary-file

81bf44b

kumaraditya303 enabled auto-merge (squash)

December 18, 2024 08:22


          Merge branch 'main' into add-warning-to-named-temporary-file

ed9ef4b

Contributor Author

graingert commented Dec 18, 2024 •

edited

Loading

Now the question remains, is this a bugfix or a feature?

kumaraditya303 merged commit bad3cde into python:main

38 checks passed

bedevere-app bot removed the awaiting merge label

graingert deleted the add-warning-to-named-temporary-file branch

December 18, 2024 10:12

Contributor

kumaraditya303 commented Dec 18, 2024

I would treat it as feature, we don't add any new warnings in stable releases.

Contributor Author

graingert commented Dec 18, 2024

Fair

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request


          pythongh-126639: Add ResourceWarning to NamedTemporaryFile (python#12…

6171ed1

…6677)

Co-authored-by: Kumar Aditya <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet