Skip to content

gh-126594: Fix typeobject.c wrap_buffer() cast #126754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2024
Merged

gh-126594: Fix typeobject.c wrap_buffer() cast #126754

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
019df14
gh-126594: Fix typeobject.c wrap_buffer() cast
vstinner Nov 12, 2024
9a6bcc7
Update Objects/typeobject.c
vstinner Nov 15, 2024
b70e0de
Merge branch 'main' into wrap_buffer
vstinner Nov 18, 2024
0351e7f
Add test
vstinner Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9314,13 +9314,13 @@ wrap_buffer(PyObject *self, PyObject *args, void *wrapped)
if (flags == -1 && PyErr_Occurred()) {
return NULL;
}
if (flags > INT_MAX) {
if (flags > INT_MAX || flags < INT_MIN) {
PyErr_SetString(PyExc_OverflowError,
"buffer flags too large");
return NULL;
}

return _PyMemoryView_FromBufferProc(self, Py_SAFE_DOWNCAST(flags, Py_ssize_t, int),
return _PyMemoryView_FromBufferProc(self, (int)flags,
(getbufferproc)wrapped);
}

Expand Down
Loading