Skip to content

Hotfix: Fix intermittent failures for the PyUnstable_Object_EnableDeferredRefcount tests #126849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Hotfix: Fix intermittent failures for the PyUnstable_Object_EnableDeferredRefcount tests #126849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions Lib/test/test_capi/test_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def test_ClearWeakRefsNoCallbacks_no_weakref_support(self):
_testcapi.pyobject_clear_weakrefs_no_callbacks(obj)


@threading_helper.requires_working_threading()
class EnableDeferredRefcountingTest(unittest.TestCase):
"""Test PyUnstable_Object_EnableDeferredRefcount"""
@support.requires_resource("cpu")
Expand All @@ -158,21 +159,13 @@ def silly_func(obj):

silly_list = [1, 2, 3]
threads = [
Thread(target=silly_func, args=(silly_list,)) for _ in range(5)
Thread(target=silly_func, args=(silly_list,)) for _ in range(4)
]

with threading_helper.catch_threading_exception() as cm:
for t in threads:
t.start()

with threading_helper.start_threads(threads):
for i in range(10):
silly_list.append(i)

for t in threads:
t.join()

self.assertIsNone(cm.exc_value)

if support.Py_GIL_DISABLED:
self.assertTrue(_testinternalcapi.has_deferred_refcount(silly_list))

Expand Down
Loading