Skip to content

gh-126944: Better error for missing arg in pdb #126945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

gh-126944: Better error for missing arg in pdb #126945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d330cb6
gh-126944: Better error for missing arg in pdb
hauntsaninja Nov 18, 2024
fc8f0e7
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 18, 2024
6d43e74
longer text
hauntsaninja Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,6 +1774,9 @@ def _getval(self, arg):
try:
return eval(arg, self.curframe.f_globals, self.curframe.f_locals)
except:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add more detailed error handling, even if it's just

expect Exception:

would be better

if not arg:
self.error("Missing argument to command!")
raise
self._error_exc()
raise

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2024-11-18-05-53-52.gh-issue-126944.WQv56W.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Better error for missing arguments in :mod:`pdb` commands.
Loading