[See Discourse] Remove peg to arbitrary minor version of python for black #126971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The cpython/.pre-commit-config.yaml Lines 30 to 35 in 0b4e13c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base thread in Discourse
Per local testing, the pre-commit hook works fine with python 3.14. I think the 3.12 peg is arbitrary. When a contributor doesn't have 3.12 installed on their machine, pre-commit won't work. This isn't a documented requirement for contributing.
I didn't create an issue for this PR because none of the categories seemed appropriate. If told to, I'll close the thread and create an issue. I don't imagine we should have both a thread and issue active at the same time. I'm open to guidance on that.