-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-112192: Increase the trace module coverage precision to one decimal #126972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, with one comment.
Also, you could change pr description to be more suitable as commit message. Just mention what you do and why it's useful.
|
cc @erlend-aasland |
Misc/NEWS.d/next/Library/2024-11-18-23-18-27.gh-issue-112192.DRdRgP.rst
Outdated
Show resolved
Hide resolved
|
Thanks for the PR, RUANG; thanks for the review Sergey. |
Before with the current trace module, you'll have a summary output like this:
This patch increase the precision of cov% to one decimal place so you'll have something like:
So, it makes the impact of small changes visible ;)
This may seem a bit non-sense at the first glance, but it's related to a very practical question - how do we know our coverage improved after some new test cases? With integer percentage, we have a 1% resolution, which means we can't tell if there's a one line improvement if the file is larger than 100 lines. For a file that has 1000 lines, the resolution is 10 lines! It's not trivial!
tracemodule #112192