Skip to content

Revert "GH-126491: GC: Mark objects reachable from roots before doing cycle collection (GH-126502)" #126983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Revert "GH-126491: GC: Mark objects reachable from roots before doing cycle collection (GH-126502)" #126983

merged 1 commit into from
Nov 19, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 18, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 18, 2024
Open
@hugovk hugovk added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 18, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @hugovk for commit 2ac5c48 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 18, 2024
@hugovk hugovk mentioned this pull request Nov 18, 2024
Merged
@hugovk hugovk marked this pull request as ready for review November 19, 2024 06:57
@hugovk hugovk merged commit 899fdb2 into python:main Nov 19, 2024
128 of 133 checks passed
@hugovk hugovk deleted the 3.14-revert-b0fcc2c branch November 19, 2024 09:25
@hugovk
Copy link
Member Author

hugovk commented Nov 19, 2024

Merged because it's 3.14.0a2 release day and there's two failing tier-1 buildbots, two failing tier-2, and six failing tier-3. Tier-1 need fixing/reverting immediately and tier-2 within 24 hours. The first failing tier-1 was 14 hours ago and tier-2 was 18 hours ago.

@AlexWaygood AlexWaygood mentioned this pull request Nov 19, 2024
Closed
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk @ebonnal
Revert "pythonGH-126491: GC: Mark objects reachable from roots before…
53b8263 
… doing cycle collection (pythonGH-126502)" (python#126983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@methane methane Awaiting requested review from methane methane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @bedevere-bot