Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 19, 2024

This catches a memory leak in loading the BUILD opcode.

This catches a memory leak in loading the BUILD opcode.
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not like I know pickle protocol internals well enough to read the bits of pickle in the tests, but they're small and I trust that you now do. :)

@serhiy-storchaka serhiy-storchaka merged commit addb225 into python:main Nov 20, 2024
48 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the pickle-test-bad-state branch November 20, 2024 15:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2024
…127031)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2024
…127031)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2024

GH-127063 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2024

GH-127064 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 20, 2024
serhiy-storchaka added a commit that referenced this pull request Nov 20, 2024
… (GH-127064)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 24, 2024
… (GH-127063)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…127031)

This catches a memory leak in loading the BUILD opcode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants