Skip to content

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Nov 23, 2024

Mainly synchronize the latest netlink constants to the socket module.

@rruuaanng rruuaanng changed the title gh-127197: Add latest netlink constants to socket module gh-127197: Add latest NETLINK_* constants to socket module Nov 30, 2024
@rruuaanng

This comment was marked as outdated.

@picnixz
Copy link
Member

picnixz commented Nov 30, 2024

I think a NEWS entry could be worthwhile as you previsouly did. There are quite a lot of macros, but you can just say "Add NETLINK_* macros for netlink vX.Y.Z when available", or say "Add NETLINK_{A,B,C,D,E,F,...} macros [...]".

@erlend-aasland
Copy link
Contributor

Does all of these make sense in a Python application? For example, what would be the use case for NETLINK_UNUSED?

@rruuaanng
Copy link
Contributor Author

Does all of these make sense in a Python application? For example, what would be the use case for NETLINK_UNUSED?

Hold on, NETLINK_UNUSED has no meaning, just as a placeholder, I'll remove it. For other constants, I'll list them one by one in the issue.
(I seem to have forgotten that I added this to the code :( )

@rruuaanng
Copy link
Contributor Author

I think a NEWS entry could be worthwhile as you previsouly did. There are quite a lot of macros, but you can just say "Add NETLINK_* macros for netlink vX.Y.Z when available", or say "Add NETLINK_{A,B,C,D,E,F,...} macros [...]".

I'll restore that NEWS entry.

@rruuaanng
Copy link
Contributor Author

I have synchronized the function note to the issue. Thank you for your participation :)

@erlend-aasland erlend-aasland changed the title gh-127197: Add latest NETLINK_* constants to socket module gh-127197: Add NETLINK_* constants to socket module Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants