Skip to content

gh-127196: Fix crash in _interpreters, when shared had invalid encodings #127220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2025
Merged

gh-127196: Fix crash in _interpreters, when shared had invalid encodings #127220

merged 2 commits into from
Jan 9, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 24, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Nov 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 24, 2024
Closed
ZeroIntensity
ZeroIntensity approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this was the fix I was thinking of. LGTM.

vstinner
vstinner approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_run_in_interpreter() fix LGTM, and tests cover the modified code path.

@sobolevn
Copy link
Member Author

Thank you! I will wait for @ericsnowcurrently's review, because this is an important part of the project.

ericsnowcurrently
ericsnowcurrently approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for the long delay!

@sobolevn sobolevn enabled auto-merge (squash) January 9, 2025 19:28
@sobolevn sobolevn merged commit 087bb48 into python:main Jan 9, 2025
41 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2025
@sobolevn @miss-islington
pythongh-127196: Fix crash in _interpreters, when shared had inva…
da3aba9 
…lid encodings (pythonGH-127220)

(cherry picked from commit 087bb48)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

GH-128689 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 9, 2025
sobolevn added a commit that referenced this pull request Jan 9, 2025
@miss-islington @sobolevn
[3.13] gh-127196: Fix crash in _interpreters, when shared had inv…
0d2b9ab 
…alid encodings (GH-127220) (#128689)

gh-127196: Fix crash in `_interpreters`, when `shared` had invalid encodings (GH-127220)
(cherry picked from commit 087bb48)

Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @vstinner @ericsnowcurrently @ZeroIntensity