Skip to content

GH-123599: Remove duplicate url2pathname() implementation #127237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 19, 2025
Merged

GH-123599: Remove duplicate url2pathname() implementation #127237

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c46ba3
GH-123599: Remove duplicate `url2pathname()` implementation
barneygale Nov 24, 2024
5e24cd4
Merge branch 'main' into gh-123599-use-urllib
barneygale Mar 18, 2025
1e515a4
Merge branch 'main' into gh-123599-use-urllib
barneygale Mar 18, 2025
eb53dd0
Merge branch 'main' into gh-123599-use-urllib
barneygale Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions Lib/pathlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,21 +1271,8 @@ def from_uri(cls, uri):
"""Return a new path from the given 'file' URI."""
if not uri.startswith('file:'):
raise ValueError(f"URI does not start with 'file:': {uri!r}")
path = uri[5:]
if path[:3] == '///':
# Remove empty authority
path = path[2:]
elif path[:12] == '//localhost/':
# Remove 'localhost' authority
path = path[11:]
if path[:3] == '///' or (path[:1] == '/' and path[2:3] in ':|'):
# Remove slash before DOS device/UNC path
path = path[1:]
if path[1:2] == '|':
# Replace bar with colon in DOS drive
path = path[:1] + ':' + path[2:]
from urllib.parse import unquote_to_bytes
path = cls(os.fsdecode(unquote_to_bytes(path)))
from urllib.request import url2pathname
path = cls(url2pathname(uri.removeprefix('file:')))
if not path.is_absolute():
raise ValueError(f"URI is not absolute: {uri!r}")
return path
Expand Down
Loading