Skip to content

gh-127258: Fix asyncio test_staggered_race_with_eager_tasks() #127259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-127258: Fix asyncio test_staggered_race_with_eager_tasks() #127259

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 25, 2024 •
edited by bedevere-app bot
Loading

Use a longer sleep for the "sleep2" task, 60 seconds instead of 2 seconds, to make sure that "sleep1" task (1 second) is more likely to win the race.

@vstinner
pythongh-127258: Fix asyncio test_staggered_race_with_eager_tasks()
6eeca7f 
Use a longer sleep for the "sleep2" task, 60 seconds instead of 2
seconds, to make sure that "sleep1" task (1 second) is more likely to
win the race.
@vstinner vstinner added tests Tests in the Lib/test dir topic-asyncio skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 25, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 25, 2024
Closed
@1st1
Copy link
Member

1st1 commented Nov 25, 2024

Maybe just add 2 locks and use them to serialize things properly? Sleeps will never work reliably

@vstinner
Copy link
Member Author

Maybe just add 2 locks and use them to serialize things properly? Sleeps will never work reliably

I wrote PR gh-127358 which replaces sleep(2) with a task which is blocked forever. Is it better?

@vstinner
Copy link
Member Author

I merged #127358 instead. Thanks for review @1st1.

@vstinner vstinner closed this Nov 29, 2024
@vstinner vstinner deleted the asyncio_staggered branch November 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @1st1