Link to correct class methods in asyncio primitives docs #127270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for asyncio Condition and Barrier links to :meth:`wait` and :meth:`wait_for`. This resolves to asyncio.wait and asyncio.wait_for instead of the respective class methods. Changing to eg :meth:`~Condition.wait` fixes this.
ollanta
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
kumaraditya303
approved these changes
Nov 29, 2024
kumaraditya303
added
topic-asyncio
skip issue
awaiting review
needs backport to 3.12
|
Thanks @ollanta for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2024
…7270) (cherry picked from commit 15d6506) Co-authored-by: Ollanta Cuba Gyllensten <[email protected]>
|
Sorry, @ollanta and @kumaraditya303, I could not cleanly backport this to |
|
GH-127423 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 29, 2024
…27270) (#127423) Link to correct class methods in asyncio primitives docs (GH-127270) (cherry picked from commit 15d6506) Co-authored-by: Ollanta Cuba Gyllensten <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
|
GH-127438 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 30, 2024
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 2, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for asyncio Condition and Barrier links to :meth:
waitand :meth:wait_for. This resolves toasyncio.waitandasyncio.wait_forinstead of the respective class methods.Changing this to eg :meth:
~Condition.waitfixes the issue.📚 Documentation preview 📚: https://cpython-previews--127270.org.readthedocs.build/