Skip to content

gh-124873: Skip timerfd tests on Android #127279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024
Merged

gh-124873: Skip timerfd tests on Android #127279

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a7b798
Revert "[3.13] gh-124873: Tolerate 100 ms in TimerfdTests on Android …
mhsmith Nov 25, 2024
7fb4ef3
Skip timerfd tests on Android
mhsmith Nov 26, 2024
34138eb
Update Lib/test/test_os.py
vstinner Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4174,12 +4174,13 @@ def test_eventfd_select(self):
os.eventfd_read(fd)

@unittest.skipUnless(hasattr(os, 'timerfd_create'), 'requires os.timerfd_create')
@unittest.skipIf(sys.platform == "android", "#124873: Test is flaky on Android")
@support.requires_linux_version(2, 6, 30)
class TimerfdTests(unittest.TestCase):
# 1 ms accuracy is reliably achievable on every platform except Android
# emulators, where we allow 100 ms (gh-124873).
# emulators, where we allow 10 ms (gh-108277).
if sys.platform == "android" and platform.android_ver().is_emulator:
CLOCK_RES_PLACES = 1
CLOCK_RES_PLACES = 2
else:
CLOCK_RES_PLACES = 3

Expand Down
Loading