gh-127314: Don't mention the GIL when calling without a thread state on the free-threaded build #127315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
requested review from
ericsnowcurrently and
markshannon
as code owners
colesbury
reviewed
Dec 2, 2024
vstinner
reviewed
Dec 2, 2024
Co-authored-by: Victor Stinner <[email protected]>
|
Apologies for the notification spam with the commits, I'm a bit on the go right now so I had to do it from GH. It's all updated now. |
vstinner
reviewed
Dec 3, 2024
Co-authored-by: Victor Stinner <[email protected]>
vstinner
approved these changes
Dec 3, 2024
|
Merged, thank you. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…state on the free-threaded build (python#127315) Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releasing the thread state via
Py_BEGIN_ALLOW_THREADScan be confusing for users on free-threading, because the common error messages that come up mention that the GIL must be held, but that won't make sense if it's disabled.(Technically, the part of the new message mentioning
Py_BEGIN_ALLOW_THREADSis true for the default build as well, but I don't see enough justification to change it there too.)NULLthread state on the free-threaded build #127314