Skip to content

gh-127316: fix incorrect assertion in setting __class__ in free-threading #127399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

gh-127316: fix incorrect assertion in setting __class__ in free-threading #127399

merged 1 commit into from
Nov 29, 2024

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Nov 29, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 29, 2024
Closed
colesbury
colesbury approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kumaraditya303 kumaraditya303 merged commit 45c5cba into python:main Nov 29, 2024
49 checks passed
@kumaraditya303 kumaraditya303 deleted the __class__ branch November 29, 2024 16:14
@kumaraditya303 kumaraditya303 added the needs backport to 3.13 bugs and security fixes label Nov 29, 2024
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2024
@kumaraditya303 @miss-islington
pythongh-127316: fix incorrect assertion in setting __class__ in fr…
5388279 
…ee-threading (pythonGH-127399)

(cherry picked from commit 45c5cba)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 29, 2024

GH-127422 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 29, 2024
kumaraditya303 added a commit that referenced this pull request Nov 29, 2024
@miss-islington @kumaraditya303
[3.13] gh-127316: fix incorrect assertion in setting __class__ in f…
2f56c68 
…ree-threading (GH-127399) (#127422)

gh-127316: fix incorrect assertion in setting `__class__` in free-threading (GH-127399)
(cherry picked from commit 45c5cba)

Co-authored-by: Kumar Aditya <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 2, 2024
@kumaraditya303 @picnixz
pythongh-127316: fix incorrect assertion in setting __class__ in fr…
dda8920 
…ee-threading (python#127399)
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@kumaraditya303 @srinivasreddy
pythongh-127316: fix incorrect assertion in setting __class__ in fr…
76b6bc4 
…ee-threading (python#127399)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@kumaraditya303 @ebonnal
pythongh-127316: fix incorrect assertion in setting __class__ in fr…
154b201 
…ee-threading (python#127399)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumaraditya303 @colesbury