Add Windows version comments to the python manifest. #127439
Conversation
| </security> | ||
| </trustInfo> | ||
| <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1"> | ||
| <application> |
There was a problem hiding this comment.
Could we add a comment linking to the docs for others?
|
Not opposed to adding the comments, though I'm not sure how valuable it is to drop entries over time. If Python happens to be run on a newer system that isn't in the manifest, Windows should use the compatibility mode for the latest version it recognises, and running in Win7 mode is better than WinXP mode (though neither are likely, tbqh). |
This is so it becomes easier to add or remove future values as time passes and when support for older versions of Windows gets dropped from python. MSVC's vNEXT (V18) will soon drop all but Windows 8.1 so if and when Python migrates to that version of MSVC that means support for Windows older than 8.1 would need to be dropped then.
|
Decided I'd rather take this without the URL. The reason being that this file is directly embedded (unmodified) inside the binaries that we ship, and it's entirely likely that embedded URLs may be treated as suspicious. If someone wants to mention this file in the devguide, that would be a suitable place to link to the docs. |
3 participants
This is so it becomes easier to add or remove future values as time passes and when support for older versions of Windows gets dropped from python. MSVC's vNEXT (V18) will soon drop all but Windows 8.1 so if and when Python migrates to that version of MSVC that means support for Windows older than 8.1 would need to be dropped then.
This is a followup PR to the change from 7 years ago (#2328) as I felt that leaving comments for the versions of windows for each specific compatibility entry is needed. It is also a trivial change as well.