gh-127411: Fix invalid conversion of load of TLBC array when compiled in C++ #127466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to reproduce the issue installing scipy and verified that running |
Fidget-Spinner
approved these changes
Dec 1, 2024
clin1234
suggested changes
Dec 1, 2024
clin1234
approved these changes
Dec 2, 2024
| static inline _PyCodeArray * | ||
| _PyCode_GetTLBCArray(PyCodeObject *co) | ||
| { | ||
| return _Py_STATIC_CAST(_PyCodeArray *, |
There was a problem hiding this comment.
I thought about _Py_STATIC_CAST when I mentioned it in the issue, but the precedent is to not use it for objects.
colesbury
approved these changes
Dec 2, 2024
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…mpiled in C++ (python#127466) Cast the result of the load to the correct type
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…mpiled in C++ (python#127466) Cast the result of the load to the correct type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast the load of the thread-local bytecode array.