gh-127529: Correct asyncio.selector_events.BaseSelectorEventLoop._accept_connection's behaviour for handling ConnectionAbortedError #127532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb2170
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
jb2170
changed the title
…tLoop._accept_connection's behaviour for handling ConnectionAbortedError
|
Force pushes to correct typo / my suckiness at reStructuredText |
|
@1st1 @asvetlov @kumaraditya303 @willingc Trivial PR to review + merge before the new year / before it fades out of memory? 🚀 |
|
You need to add tests for this. |
…abortederror to test graceful handling of ConnectionAbortedError
|
Hi @kumaraditya303 , thanks for the reply! I've added a test to |
Misc/NEWS.d/next/Library/2024-12-02-19-13-19.gh-issue-127529.Pj1Xtf.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2024-12-02-19-13-19.gh-issue-127529.Pj1Xtf.rst
Outdated
Show resolved
Hide resolved
kumaraditya303
approved these changes
Jan 3, 2025
WolframAlph
pushed a commit
to WolframAlph/cpython
that referenced
this pull request
Jan 4, 2025
…handling `ConnectionAbortedError` (python#127532) Co-authored-by: Kumar Aditya <[email protected]>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…handling `ConnectionAbortedError` (python#127532) Co-authored-by: Kumar Aditya <[email protected]>
|
@kumaraditya303 don't we want to backport this to 3.13? WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127529
All good to go.
ConnectionAbortedErrornowcontinues instead ofreturning. Improves OpenBSD performance. Full writeup in the issue.I've left
InterruptedErrorgrouped withBlockingIOErrorto bothreturnearly, instead ofInterruptedErrorcontinueing andBlockingIOErrorreturning. PEP-475 should makeInterruptedErrornever appear right, but hey if it's not broken don't fix it. Best to play it safe with the urgency of signals, especially as asyncio uses them for a wakeup fd.BaseSelectorEventLoop._accept_connectionreturns when it shouldcontinueonConnectionAbortedError#127529