Skip to content

gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces #127575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 5, 2024
Merged

gh-127434: Fix iOS xcrun --sdk clang/ar scripts to allow arguments with spaces #127575

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c728ae8
Fix iOS `xcrun --sdk` clang/ar scripts to allow arguments with spaces
FeodorFitsner Dec 3, 2024
e494265
Merge remote-tracking branch 'upstream/main' into ios-fix-xcrun-clang…
FeodorFitsner Dec 4, 2024
ab2ddf7
Create 2024-12-04-09-52-08.gh-issue-127434.RjkGT_.rst
FeodorFitsner Dec 4, 2024
9356299
Update Misc/NEWS.d/next/Core_and_Builtins/2024-12-04-09-52-08.gh-issu…
FeodorFitsner Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2024-12-04-09-52-08.gh-issue-127434.RjkGT_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix clang/ar scripts in `iOS/Resources/bin` directory to allow arguments
with spaces.
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-ar
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} ar $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} ar "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-clang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-clang++
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang++ -target arm64-apple-ios $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang++ -target arm64-apple-ios "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios -E $@
xcrun --sdk iphoneos${IOS_SDK_VERSION} clang -target arm64-apple-ios -E "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-ar
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-clang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-clang++
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target arm64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target arm64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/arm64-apple-ios-simulator-cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator -E $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target arm64-apple-ios-simulator -E "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-ar
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} ar "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-clang
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-clang++
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target x86_64-apple-ios-simulator $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang++ -target x86_64-apple-ios-simulator "$@"
2 changes: 1 addition & 1 deletion iOS/Resources/bin/x86_64-apple-ios-simulator-cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
#!/bin/sh
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator -E $@
xcrun --sdk iphonesimulator${IOS_SDK_VERSION} clang -target x86_64-apple-ios-simulator -E "$@"
Loading