-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-127586: properly restore blocked signals in resource_tracker.py #127587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gpshead
merged 9 commits into
python:main
from
stephen-hansen:gh-127586-mp-pool-sigblock-fix
Dec 15, 2024
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
292d37e
Correct pthread_sigmask in resource_tracker to restore old signals
stephen-hansen 5e4797c
Adding NEWS on mp.Pool signal handling
stephen-hansen da95ed3
Fixing mp Pool class path in NEWS
stephen-hansen dcc52ba
Update Misc/NEWS.d/next/Library/2024-12-03-20-28-08.gh-issue-127586.z…
stephen-hansen 2d30d44
Merge branch 'main' into gh-127586-mp-pool-sigblock-fix
stephen-hansen 41731d7
Adding resource_tracker blocked signals test
stephen-hansen 47e7b67
Linter fix
stephen-hansen 070e3e8
Update Lib/test/_test_multiprocessing.py
stephen-hansen 82d49e3
fix the test skip
gpshead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
Misc/NEWS.d/next/Library/2024-12-03-20-28-08.gh-issue-127586.zgotYF.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| :class:`multiprocessing.pool.Pool` now properly restores blocked signal handlers | ||
| of the parent thread when creating processes via either *spawn* or | ||
| *forkserver*. Previously it would unblock **SIGTERM** and **SIGINT** in the | ||
| parent thread on construction, even if either signal handler was | ||
| intentionally blocked prior to the call to construct. Additionally, child | ||
| processes can now inherit said blocked signals. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.