Skip to content

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Dec 5, 2024

@hoodmane hoodmane changed the title gh-127627: Add os._emscripten_debugger function gh-127627: Add posix._emscripten_debugger function Dec 5, 2024
@hoodmane
Copy link
Contributor Author

hoodmane commented Dec 5, 2024

I guess since it's private it doesn't make it onto the os module.

Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems like a straightforward addition. I guess it makes sense to keep it private initially; it's easy enough to promote to a public API if it seems worthwhile to do so in future.

@freakboy3742 freakboy3742 merged commit 25eee57 into python:main Dec 6, 2024
41 checks passed
@hoodmane
Copy link
Contributor Author

hoodmane commented Dec 6, 2024

I suspect this is very niche -- it's useful for debugging and fixing faulty emscripten syscalls. But perhaps other people will find more common uses for it.

@hoodmane hoodmane deleted the emscripten-debugger branch December 6, 2024 11:45
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
…7628)

Add a posix._emscripten_debugger function to add an emscripten breakpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants